-
-
Notifications
You must be signed in to change notification settings - Fork 26
Update template path for router.js #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like this change has broken the router generation, the generated file ( module.exports = (api, options) => {
require('@vue/cli-plugin-router/generator')(api, {
historyMode: options.routerHistoryMode,
};
export default new Router(options);
}; This is definitely not the desired result. A After manually refactoring |
can you please tell me what should i update in router/index.js file and in routes.reduce function ?? |
I would also love to know how to fix this error. |
@Darshan197 @aspickard I don't have my changes anymore, but I will re-check and share what I've done... Just been a few really busy weeks. |
Thanks so much I'm just starting nativescript and it's been a pretty bumpy start haha. I got through a few other setup errors but this one was the last straw :p |
So if anyone needs a work around you can check this out: Obviously it's just doing a file replace of the router.js, but personally I think that's better than monkeypatching with the regex like it was done before 🤷 Also if you are using the nvw template you will have to apply the stylesheet fixes. |
Fix for #34